Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Simplify the WorkflowTemplateRef field validation to support all fields in WorkflowSpec except Templates #3632

Merged
merged 5 commits into from Jul 29, 2020
Merged

fix: Simplify the WorkflowTemplateRef field validation to support all fields in WorkflowSpec except Templates #3632

merged 5 commits into from Jul 29, 2020

Conversation

sarabala1979
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234". Fixes Unable to use workflowTemplateRef with defaults workflow serviceAccountName #3355
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@sarabala1979 sarabala1979 marked this pull request as ready for review July 29, 2020 21:45
@sarabala1979 sarabala1979 requested a review from alexec July 29, 2020 21:45
alexec
alexec approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to back-port to v2.10?

@sarabala1979
Copy link
Member Author

yes

@sarabala1979 sarabala1979 merged commit 5b0210d into argoproj:master Jul 29, 2020
sarabala1979 added a commit that referenced this pull request Jul 29, 2020
@sarabala1979
fix: Simplify the WorkflowTemplateRef field validation to support all…
0b8d78e 
… fields in WorkflowSpec except `Templates` (#3632)
sarabala1979 added a commit that referenced this pull request Jul 29, 2020
@sarabala1979
fix: Simplify the WorkflowTemplateRef field validation to support all…
c7512b6 
… fields in WorkflowSpec except `Templates` (#3632)
@alexec
Copy link
Contributor

alexec commented Aug 3, 2020

Fixed and available in v2.10.0-rc5.

@vladlosev
Copy link
Contributor

Thanks! I see it has also been backported to the 2.9 branch. Can you please tag a point release on that branch with the fix?

@alexec
Copy link
Contributor

alexec commented Aug 6, 2020

Available in v2.9.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees

@alexec alexec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to use workflowTemplateRef with defaults workflow serviceAccountName
3 participants
@sarabala1979 @alexec @vladlosev