fix: Avoid overriding the Workflow parameter when it is merging with WorkflowTemplate parameter #3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WorkflowTemplate parameter
alexec
reviewed
Jul 31, 2020
| @@ -2925,7 +2925,7 @@ func (woc *wfOperationCtx) loadExecutionSpec() (wfv1.TemplateReferenceHolder, wf | |||
| } | |||
|
|
|||
| // Merge the workflow spec and storedWorkflowspec. | |||
| targetWf := wfv1.Workflow{Spec: woc.wf.Spec} | |||
| targetWf := wfv1.Workflow{Spec: *woc.wf.Spec.DeepCopy()} | |||
alexec
approved these changes
Jul 31, 2020
sarabala1979
added a commit
that referenced
this pull request
Jul 31, 2020
…WorkflowTemplate parameter (#3651)
sarabala1979
added a commit
that referenced
this pull request
Jul 31, 2020
…WorkflowTemplate parameter (#3651)
|
backported to 2.9 and 2.10 |
|
Fixed and available in v2.10.0-rc5. |
|
Available in v2.9.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234". Fixes v2.9.4: Parameter file with WorkflowTemplate items unset #3630