Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Report v1.Status errors. Fixes #3608 #3652

Merged
merged 1 commit into from Jul 31, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jul 31, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Fixes #3608

I was incorrect in my solution to #3608. Re-establishing a watch can result in an infinite loop and therefore the server consuming 100% CPU. One instance when this happens is when listOptions.resourceVersion has "too old resource version" (e.g. old browser window left open).

This PR does:

  • Essentially reverts the original fix.
  • Reports v1.Status errors as warnings rather than error in the workflow-logger.go.
  • Return a v1.Status error back to the client for workflow watch.

@alexec alexec requested a review from simster7 July 31, 2020 17:03
@alexec alexec marked this pull request as ready for review July 31, 2020 18:00
@alexec alexec merged commit a8f4da0 into argoproj:master Jul 31, 2020
@alexec alexec deleted the fix-3608-v2 branch July 31, 2020 22:50
@alexec
Copy link
Contributor Author

alexec commented Aug 3, 2020

Fixed and available in v2.10.0-rc5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-establish watch on watch object was not a workflow *v1.Status error
2 participants