fix(server): Report v1.Status errors. Fixes #3608 #3652
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.Fixes #3608
I was incorrect in my solution to #3608. Re-establishing a watch can result in an infinite loop and therefore the server consuming 100% CPU. One instance when this happens is when
listOptions.resourceVersion
has "too old resource version" (e.g. old browser window left open).This PR does:
v1.Status
errors as warnings rather than error in theworkflow-logger.go
.v1.Status
error back to the client for workflow watch.