Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): Synchronization lock didn't release on DAG call flow Fixes #4046 #4263

Merged
merged 2 commits into from Oct 14, 2020
Merged

fix(controller): Synchronization lock didn't release on DAG call flow Fixes #4046 #4263

merged 2 commits into from Oct 14, 2020

Conversation

sarabala1979
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • My organization is added to USERS.md.
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.

Fixes #4046

@alexec alexec self-assigned this Oct 13, 2020
@alexec alexec changed the title fix(controller): Synchronization lock didn't release on DAG cal flow Fixes #4046 fix(controller): Synchronization lock didn't release on DAG call flow Fixes #4046 Oct 13, 2020
alexec
alexec approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test?

@sarabala1979 sarabala1979 merged commit c605c6d into argoproj:master Oct 14, 2020
alexec
alexec reviewed Oct 15, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport!

sarabala1979 added a commit that referenced this pull request Oct 15, 2020
@sarabala1979
fix(controller): Synchronization lock didn't release on DAG call flow F…
0551942 
…ixes #4046 (#4263)
@alexec alexec added this to the v2.12 milestone Oct 15, 2020
alexcapras pushed a commit to alexcapras/argo that referenced this pull request Nov 12, 2020
@sarabala1979 @alexcapras
fix(controller): Synchronization lock didn't release on DAG call flow F…
4cf6fa1 
…ixes argoproj#4046 (argoproj#4263)

Signed-off-by: Alex Capras <alexcapras@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees

@alexec alexec

Labels
None yet
Projects
None yet
Milestone
v2.12
Development

Successfully merging this pull request may close these issues.

Step or dag workflows do not seem to release semaphore locks
2 participants
@sarabala1979 @alexec