Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(controller): Allow whitespace in variable subsitution. Fixes #4286 #4310

Merged
merged 1 commit into from
Oct 17, 2020
Merged

feat(controller): Allow whitespace in variable subsitution. Fixes #4286 #4310

merged 1 commit into from
Oct 17, 2020

Conversation

idsvandermolen
Copy link
Contributor

@idsvandermolen idsvandermolen commented Oct 17, 2020 •
edited

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • My organization is added to USERS.md.
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@idsvandermolen idsvandermolen mentioned this pull request Oct 17, 2020
Closed
@alexec alexec merged commit e6b0249 into argoproj:master Oct 17, 2020
alexcapras pushed a commit to alexcapras/argo that referenced this pull request Nov 12, 2020
@idsvandermolen @alexcapras
feat(controller): Allow whitespace in variable substitution. Fixes ar…
93f273c 
…goproj#4286 (argoproj#4310)

Signed-off-by: Alex Capras <alexcapras@gmail.com>
simster7 pushed a commit that referenced this pull request Nov 17, 2020
@idsvandermolen @simster7
feat(controller): Allow whitespace in variable substitution. Fixes #4286
66f2306 
 (#4310)
This was referenced Nov 17, 2020
Closed
Closed
@simster7
Copy link
Member

Back-ported to 2.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@idsvandermolen @CLAassistant @simster7 @alexec