fix(executor): Increase pod patch backoff. Fixes #4339 #4340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be awesome if you could release this fix soon because its a real deal breaker for us currently. 👍 |
alexec
changed the title
alexec
commented
Oct 22, 2020
| // 1 1.000 | ||
| // 2 2.600 | ||
| // 3 5.160 | ||
| // 4 9.256 | ||
| var ExecutorRetry = wait.Backoff{ | ||
| Steps: 5, |
There was a problem hiding this comment.
maybe even more steps?
whynowy
reviewed
Oct 22, 2020
This reverts commit 0c5e615. Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
added a commit
that referenced
this pull request
Oct 23, 2020
alexcapras
pushed a commit
to alexcapras/argo
that referenced
this pull request
Nov 12, 2020
…roj#4340) Signed-off-by: Alex Capras <alexcapras@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.Fixes #4339