fix(server): Download artifacts from UI. Fixes #4338 #4350
Conversation
Signed-off-by: Alex Collins <alex_collins@intuit.com>
| @@ -137,8 +137,7 @@ func (a *ArtifactServer) getArtifact(ctx context.Context, wf *wfv1.Workflow, nod | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
|
|
|||
| tmp, err := ioutil.TempFile(".", "artifact") | |||
| tmp, err := ioutil.TempFile("/tmp", "artifact") | |||
There was a problem hiding this comment.
Will it be automatically deleted? Or do we need to delete it?
https://golang.org/pkg/io/ioutil/#TempFile
There was a problem hiding this comment.
already done - see below:
defer func() { _ = os.Remove(path) }()
There was a problem hiding this comment.
this change broke the output artifact downloads for us, we upgraded from 2.11.5 to 2.11.7, and we began to get errors like this:
open /tmp/artifact058606664: no such file or directory
reverting the upgrade fixed the downloads.
There was a problem hiding this comment.
@ekesken - likely using runAsNonRoot? You'll need to mount /tmp as an emptyDir volume on argo-server pod so you can write to it. This path should probably be configurable as an argument.
There was a problem hiding this comment.
I see that the fix in helm chart is already merged here: argoproj/argo-helm@9939da5
It was surprising to see a non-backward compatible change in a patch version change, that's why I wanted to point it here.
alexec
added
the
type/regression
|
Back-ported to v2.11 |
…j#4350) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Alex Capras <alexcapras@gmail.com>
agilgur5
added
area/manifests
area/artifacts
Signed-off-by: Alex Collins alex_collins@intuit.com
Checklist:
"fix(controller): Updates such and such. Fixes #1234".I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.Fixes #4338