feat(controller): Support per-output parameter aggregation. Fixes #2393 #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ark-kun
force-pushed
the
Support-per-output-parameter-aggregation
branch
2 times, most recently
from
fd0551e
to
e7fd44c
Compare
Ark-kun
changed the title
Ark-kun
force-pushed
the
Support-per-output-parameter-aggregation
branch
from
e7fd44c
to
055058f
Compare
|
@Ark-kun please mark this as "Ready for Review" when it's so and I'll take a look |
|
@Ark-kun we're going to review some unfinished PRs to determine if we should finish them. Do you plan to continue on this, please? |
alexec
changed the title
Ark-kun
force-pushed
the
Support-per-output-parameter-aggregation
branch
4 times, most recently
from
38638d2
to
f1bef2d
Compare
Currently Argo only supports the `{{tasks.<TASKNAME>.outputs.parameters.<NAME>}}` placeholder for the outputs of normal nodes. (For the outputs of the loop nodes there is the `{{tasks.<TASKNAME>.outputs.parameters}}` placeholder, which is replaced with JSON-serialized list of parameter value maps.
This PR adds support for the `{{tasks.<TASKNAME>.outputs.parameters.<NAME>}}` placeholder for the outputs of the loop nodes. The placeholder is replaced with JSON-serialized list of parameter values.
Signed-off-by: Alexey Volkov <alexey.volkov@ark-kun.com>
Ark-kun
force-pushed
the
Support-per-output-parameter-aggregation
branch
from
f1bef2d
to
252257a
Compare
simster7
reviewed
Dec 4, 2020
This would be great, but I have not found the tests for the main feature (parameter aggregation), so it looks like this will require non-trivial amount of work. |
simster7
approved these changes
Dec 9, 2020
|
Will we see this PR released in argo v2.13? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Argo only supports the
{{tasks.<TASKNAME>.outputs.parameters.<NAME>}}placeholder for the outputs of normal nodes. (For the outputs of the loop nodes there is the{{tasks.<TASKNAME>.outputs.parameters}}placeholder, which is replaced with JSON-serialized list of parameter value maps.This PR adds support for the
{{tasks.<TASKNAME>.outputs.parameters.<NAME>}}placeholder for the outputs of the loop nodes. The placeholder is replaced with JSON-serialized list of parameter values.Fixes #2393
Checklist:
"fix(controller): Updates such and such. Fixes #1234".