fix(ui): Reconnect to DAG. Fixes #4301 #4378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <alex_collins@intuit.com>
…details.tsx Signed-off-by: Alex Collins <alex_collins@intuit.com>
simster7
reviewed
Oct 27, 2020
| @@ -47,6 +47,10 @@ export class WorkflowDetails extends React.Component<RouteComponentProps<any>, W | |||
| private changesSubscription: Subscription; | |||
| private timelineComponent: WorkflowTimeline; | |||
|
|
|||
| private get resourceVersion() { | |||
| return this.state.workflow && this.state.workflow.metadata.resourceVersion; | |||
There was a problem hiding this comment.
If this.state.workflow.metadata === null, then we could have a NPE
There was a problem hiding this comment.
I don't think this.state.workflow.metadata could ever be null? That would be an anonymous resource. I don't think you can have them?
There was a problem hiding this comment.
Even so, it would probably be good for our code to be tolerant
simster7
approved these changes
Oct 27, 2020
alexec
added a commit
that referenced
this pull request
Oct 27, 2020
alexcapras
pushed a commit
to alexcapras/argo
that referenced
this pull request
Nov 12, 2020
Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Alex Capras <alexcapras@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins alex_collins@intuit.com
Checklist:
"fix(controller): Updates such and such. Fixes #1234".I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.