Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct template when processing metrics #4399

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

simster7
Copy link
Member

Fixes: #4381

Signed-off-by: Simon Behar simbeh7@gmail.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • My organization is added to USERS.md.
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.

Signed-off-by: Simon Behar <simbeh7@gmail.com>
@alexec
Copy link
Contributor

alexec commented Oct 28, 2020

Backport?

@simster7 simster7 merged commit 2821e4e into argoproj:master Oct 28, 2020
simster7 added a commit that referenced this pull request Oct 28, 2020
Signed-off-by: Simon Behar <simbeh7@gmail.com>
@simster7
Copy link
Member Author

Back-ported to 2.11

@dinever
Copy link
Member

dinever commented Oct 28, 2020

Hi @simster7, thanks for the fix! When can we expect a new tag being created? Thanks!

alexcapras pushed a commit to alexcapras/argo that referenced this pull request Nov 12, 2020
Signed-off-by: Simon Behar <simbeh7@gmail.com>
Signed-off-by: Alex Capras <alexcapras@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template metrics not working from within WorkflowTemplate
4 participants