Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Assume controller is in UTC when calculating NextScheduledRuntime #4417

Merged
merged 5 commits into from
Nov 2, 2020

Conversation

simster7
Copy link
Member

Fixes: #4325

WIP

Signed-off-by: Simon Behar simbeh7@gmail.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • My organization is added to USERS.md.
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.

Signed-off-by: Simon Behar <simbeh7@gmail.com>
Signed-off-by: Simon Behar <simbeh7@gmail.com>
Signed-off-by: Simon Behar <simbeh7@gmail.com>
@simster7 simster7 marked this pull request as ready for review October 29, 2020 19:23
Signed-off-by: Simon Behar <simbeh7@gmail.com>
@simster7 simster7 merged commit 7f2ff80 into argoproj:master Nov 2, 2020
simster7 added a commit that referenced this pull request Nov 2, 2020
@simster7
Copy link
Member Author

simster7 commented Nov 2, 2020

Back-ported to 2.11

alexcapras pushed a commit to alexcapras/argo that referenced this pull request Nov 12, 2020
argoproj#4417)

Signed-off-by: Simon Behar <simbeh7@gmail.com>
Signed-off-by: Alex Capras <alexcapras@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argo cron list *NEXT RUN* report wrong if timezone is not set
2 participants