feat(controller): Enhanced artifact repository ref. See #3184 #4458

alexec · 2020-11-04T18:26:21Z

Signed-off-by: Alex Collins alex_collins@intuit.com

Checklist:

My organization is added to USERS.md.

This PR allows you to:

Configure a default artifact repository at namespace-level.

Signed-off-by: Alex Collins <alex_collins@intuit.com>

alexec · 2020-11-04T19:07:21Z

TestFunctionalSuite/TestArtifactRepositoryRef

Signed-off-by: Alex Collins <alex_collins@intuit.com>

docs/artifact-repository-ref.md

Signed-off-by: Alex Collins <alex_collins@intuit.com>

alexec · 2020-11-05T20:52:48Z

make codegen

Signed-off-by: Alex Collins <alex_collins@intuit.com>

alexec · 2020-11-10T02:05:14Z

@sarabala1979 @jessesuen reviewed and approved the proto changes. Over to you to review the code changes - thank you.

sarabala1979 · 2020-11-12T22:55:34Z

manifests/base/crds/full/argoproj.io_workflows.yaml

@@ -6703,6 +6703,17 @@ spec:
          type: object
        status:
          properties:
+            artifactRepositoryRef:
+              properties:
+                configMap:


instead configMap and Key, is it possible to use configMapKeyRef?

This is prior-art. ArtifactRepositoryRefStatus sub-classes ArtifactRepositoryRef, I'd like to keep it like this.

workflow/controller/operator.go

Signed-off-by: Alex Collins <alex_collins@intuit.com>

changes made

Signed-off-by: Alex Collins <alex_collins@intuit.com>

alexec · 2020-11-16T20:26:02Z

I want to hold this for a few days so we can do v2.12 fixes for it.

Signed-off-by: Alex Collins <alex_collins@intuit.com>

alexec · 2020-11-30T22:27:13Z

@sarabala1979 @simster7 @jessesuen this is a decent sized change to artifact management. Any issues on master in that area - this is the likely cause.

Signed-off-by: github@finnesand.no <github@finnesand.no> feat(ui): Add Template/Cron workflow filter to workflow page. Closes argoproj#4532 (argoproj#4543) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> feat(executor): Auto create s3 bucket if not present. Signed-off-by: Alex Capras <alexcapras@gmail.com> Apply codegen Signed-off-by: Alex Capras <alexcapras@gmail.com> Add argo-e2e label to test wf Signed-off-by: Alex Capras <alexcapras@gmail.com> chore: Updated stress test YAML (argoproj#4569) Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Updated kubectl apply command in manifests README (argoproj#4577) Signed-off-by: Stefan Gloutnikov <stefan@gloutnikov.com> feat(controller): Make MAX_OPERATION_TIME configurable. Close argoproj#4239 (argoproj#4562) Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Fix a typo in example (argoproj#4590) Signed-off-by: Takayoshi Nishida <takayoshi.nishida@gmail.com> feat(controller): Retry transient offload errors. Resolves argoproj#4464 (argoproj#4482) Signed-off-by: Alex Collins <alex_collins@intuit.com> fix(server): use the correct name when downloading artifacts (argoproj#4579) Signed-off-by: Daniel Herman <dherman@factset.com> fix(server): serve artifacts directly from disk to support large artifacts (argoproj#4589) Signed-off-by: Daniel Herman <dherman@factset.com> fix(executor): Handle sidecar killing in a process-namespace-shared pod (argoproj#4575) Signed-off-by: Daisuke Taniwaki <daisuketaniwaki@gmail.com> docs: Add JSON schema for IDE validation (argoproj#4581) Signed-off-by: Paul Brabban <paul.brabban@gmail.com> refactor: Use polling model for workflow phase metric (argoproj#4557) Signed-off-by: Simon Behar <simbeh7@gmail.com> Addressing reviewers comments Signed-off-by: Alex Capras <alexcapras@gmail.com> Addressing reviewers comments docs: Minor typo fix (argoproj#4610) Signed-off-by: Paavo Pokkinen <paavo.pokkinen@vaimo.com> fix(controller): Prevent tasks with names starting with digit to use either 'depends' or 'dependencies' (argoproj#4598) Signed-off-by: terrytangyuan <terrytangyuan@gmail.com> fix(docs): Bring minio chart instructions up to date (argoproj#4586) Signed-off-by: Ranga Krishnan <ranga@bei.re> fix(executor): Fixed waitMainContainerStart returning prematurely. Closes argoproj#4599 (argoproj#4601) Signed-off-by: fsiegmund <siegmund@slb.com> feat(controller): Enhanced artifact repository ref. See argoproj#3184 (argoproj#4458) Signed-off-by: Alex Collins <alex_collins@intuit.com> fix: Null check pagination variable (argoproj#4617) Signed-off-by: Simon Behar <simbeh7@gmail.com> fix: Perform fields filtering server side (argoproj#4595) Signed-off-by: Simon Behar <simbeh7@gmail.com> fix(server): Correct webhook event payload marshalling. Fixes argoproj#4572 (argoproj#4594) Signed-off-by: Alex Collins <alex_collins@intuit.com> feat(ui): Add columns--narrower-height to AttributeRow (argoproj#4371) fix: Fix TestCleanFieldsExclude (argoproj#4625) Signed-off-by: Simon Behar <simbeh7@gmail.com> fix(argo-server): fix global variable validation error with reversed dag.tasks (argoproj#4369) Signed-off-by: chenyu.zheng <chenyu.zheng@hulu.com> fix: derive jsonschema and fix up issues, validate examples dir… (argoproj#4611) Signed-off-by: Paul Brabban <paul.brabban@gmail.com> fix(ui): Reference secrets in EnvVars. Fixes argoproj#3973 (argoproj#4419) Signed-off-by: Alejandro Tejera <aletepe@gmail.com> fix(ui): Fix Snyk issues (argoproj#4631) Signed-off-by: Alex Collins <alex_collins@intuit.com> feat(executor): More informative log when executors do not support output param from base image layer (argoproj#4620) Signed-off-by: terrytangyuan <terrytangyuan@gmail.com> Codegen patch. Signed off by alexcapras@gmail.com Codegen patch. Signed off by alexcapras@gmail.com Delete test.patch

Signed-off-by: github@finnesand.no <github@finnesand.no> feat(ui): Add Template/Cron workflow filter to workflow page. Closes argoproj#4532 (argoproj#4543) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> feat(executor): Auto create s3 bucket if not present. Signed-off-by: Alex Capras <alexcapras@gmail.com> Apply codegen Signed-off-by: Alex Capras <alexcapras@gmail.com> Add argo-e2e label to test wf Signed-off-by: Alex Capras <alexcapras@gmail.com> chore: Updated stress test YAML (argoproj#4569) Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Updated kubectl apply command in manifests README (argoproj#4577) Signed-off-by: Stefan Gloutnikov <stefan@gloutnikov.com> feat(controller): Make MAX_OPERATION_TIME configurable. Close argoproj#4239 (argoproj#4562) Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Fix a typo in example (argoproj#4590) Signed-off-by: Takayoshi Nishida <takayoshi.nishida@gmail.com> feat(controller): Retry transient offload errors. Resolves argoproj#4464 (argoproj#4482) Signed-off-by: Alex Collins <alex_collins@intuit.com> fix(server): use the correct name when downloading artifacts (argoproj#4579) Signed-off-by: Daniel Herman <dherman@factset.com> fix(server): serve artifacts directly from disk to support large artifacts (argoproj#4589) Signed-off-by: Daniel Herman <dherman@factset.com> fix(executor): Handle sidecar killing in a process-namespace-shared pod (argoproj#4575) Signed-off-by: Daisuke Taniwaki <daisuketaniwaki@gmail.com> docs: Add JSON schema for IDE validation (argoproj#4581) Signed-off-by: Paul Brabban <paul.brabban@gmail.com> refactor: Use polling model for workflow phase metric (argoproj#4557) Signed-off-by: Simon Behar <simbeh7@gmail.com> Addressing reviewers comments Signed-off-by: Alex Capras <alexcapras@gmail.com> Addressing reviewers comments docs: Minor typo fix (argoproj#4610) Signed-off-by: Paavo Pokkinen <paavo.pokkinen@vaimo.com> fix(controller): Prevent tasks with names starting with digit to use either 'depends' or 'dependencies' (argoproj#4598) Signed-off-by: terrytangyuan <terrytangyuan@gmail.com> fix(docs): Bring minio chart instructions up to date (argoproj#4586) Signed-off-by: Ranga Krishnan <ranga@bei.re> fix(executor): Fixed waitMainContainerStart returning prematurely. Closes argoproj#4599 (argoproj#4601) Signed-off-by: fsiegmund <siegmund@slb.com> feat(controller): Enhanced artifact repository ref. See argoproj#3184 (argoproj#4458) Signed-off-by: Alex Collins <alex_collins@intuit.com> fix: Null check pagination variable (argoproj#4617) Signed-off-by: Simon Behar <simbeh7@gmail.com> fix: Perform fields filtering server side (argoproj#4595) Signed-off-by: Simon Behar <simbeh7@gmail.com> fix(server): Correct webhook event payload marshalling. Fixes argoproj#4572 (argoproj#4594) Signed-off-by: Alex Collins <alex_collins@intuit.com> feat(ui): Add columns--narrower-height to AttributeRow (argoproj#4371) fix: Fix TestCleanFieldsExclude (argoproj#4625) Signed-off-by: Simon Behar <simbeh7@gmail.com> fix(argo-server): fix global variable validation error with reversed dag.tasks (argoproj#4369) Signed-off-by: chenyu.zheng <chenyu.zheng@hulu.com> fix: derive jsonschema and fix up issues, validate examples dir… (argoproj#4611) Signed-off-by: Paul Brabban <paul.brabban@gmail.com> fix(ui): Reference secrets in EnvVars. Fixes argoproj#3973 (argoproj#4419) Signed-off-by: Alejandro Tejera <aletepe@gmail.com> fix(ui): Fix Snyk issues (argoproj#4631) Signed-off-by: Alex Collins <alex_collins@intuit.com> feat(executor): More informative log when executors do not support output param from base image layer (argoproj#4620) Signed-off-by: terrytangyuan <terrytangyuan@gmail.com> Codegen patch. Signed off by alexcapras@gmail.com Codegen patch. Signed off by alexcapras@gmail.com Delete test.patch Signed-off-by: Alex Capras <alexcapras@gmail.com>

alexec added 2 commits November 4, 2020 10:25

feat(controller): Enhanced artifact repostitory ref. See argoproj#3184

f734314

Signed-off-by: Alex Collins <alex_collins@intuit.com>

artref: M api/openapi-spec/swagger.json

a8f1aa5

Signed-off-by: Alex Collins <alex_collins@intuit.com>

alexec marked this pull request as ready for review November 4, 2020 19:07

alexec requested a review from jessesuen as a code owner November 4, 2020 19:07

sarabala1979 assigned jessesuen and sarabala1979 Nov 4, 2020

artref: M test/e2e/testdata/artifact-repository-ref.yaml

63df09b

Signed-off-by: Alex Collins <alex_collins@intuit.com>

jessesuen reviewed Nov 5, 2020

View reviewed changes

docs/artifact-repository-ref.md Outdated Show resolved Hide resolved

alexec added 3 commits November 5, 2020 11:42

Merge branch 'master' into artref

f2db578

Signed-off-by: Alex Collins <alex_collins@intuit.com>

artref: M docs/artifact-repository-ref.md

347edd4

Signed-off-by: Alex Collins <alex_collins@intuit.com>

artref: M docs/artifact-repository-ref.md

e69b6ba

Signed-off-by: Alex Collins <alex_collins@intuit.com>

alexec added 3 commits November 5, 2020 14:36

Merge branch 'master' into artref

48b4cf5

Signed-off-by: Alex Collins <alex_collins@intuit.com>

Merge branch 'master' into artref

2f62910

Signed-off-by: Alex Collins <alex_collins@intuit.com>

artref: M api/openapi-spec/swagger.json

e4aa73e

Signed-off-by: Alex Collins <alex_collins@intuit.com>

jessesuen approved these changes Nov 9, 2020

View reviewed changes

Merge branch 'master' into artref

208d39c

alexec assigned sarabala1979 and unassigned jessesuen and sarabala1979 Nov 9, 2020

alexec added 2 commits November 9, 2020 13:04

artref: M workflow/controller/operator.go

2fb0639

Signed-off-by: Alex Collins <alex_collins@intuit.com>

Merge branch 'master' into artref

47f36e6

Signed-off-by: Alex Collins <alex_collins@intuit.com>

sarabala1979 previously requested changes Nov 12, 2020

View reviewed changes

alexec added 2 commits November 15, 2020 20:21

Merge branch 'master' into artref

40e51a4

Signed-off-by: Alex Collins <alex_collins@intuit.com>

artref: M workflow/controller/operator.go

526b5a0

Signed-off-by: Alex Collins <alex_collins@intuit.com>

alexec requested a review from sarabala1979 November 16, 2020 04:25

sarabala1979 approved these changes Nov 16, 2020

View reviewed changes

Merge branch 'master' into artref

b845d6f

Signed-off-by: Alex Collins <alex_collins@intuit.com>

alexec added the do not merge label Nov 16, 2020

alexec marked this pull request as draft November 16, 2020 20:26

alexec added 4 commits November 17, 2020 07:36

Merge branch 'master' into artref

4456f00

Signed-off-by: Alex Collins <alex_collins@intuit.com>

artref: M pkg/apis/workflow/v1alpha1/generated.pb.go

4614a77

Signed-off-by: Alex Collins <alex_collins@intuit.com>

codegen

3d04e3e

Signed-off-by: Alex Collins <alex_collins@intuit.com>

artref: M workflow/controller/operator_test.go

012f22d

Signed-off-by: Alex Collins <alex_collins@intuit.com>

alexec added this to the v3.0 milestone Nov 20, 2020

This was linked to issues Nov 23, 2020

Configure artifacts using URIs, e.g s3://my-bucket/my-key #4349

Open

Reduce node status bloat #3051

Closed

alexec marked this pull request as ready for review November 30, 2020 21:35

alexec removed the do not merge label Nov 30, 2020

alexec added 4 commits November 30, 2020 13:39

Merge branch 'master' into artref

ffe2ced

Signed-off-by: Alex Collins <alex_collins@intuit.com>

artref: M server/artifacts/artifact_server.go

e8e6c70

Signed-off-by: Alex Collins <alex_collins@intuit.com>

artref: M api/jsonschema/schema.json

0618520

Signed-off-by: Alex Collins <alex_collins@intuit.com>

artref: M server/artifacts/artifact_server.go

6070601

Signed-off-by: Alex Collins <alex_collins@intuit.com>

alexec merged commit c84d56b into argoproj:master Nov 30, 2020

alexec deleted the artref branch November 30, 2020 22:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(controller): Enhanced artifact repository ref. See #3184 #4458

feat(controller): Enhanced artifact repository ref. See #3184 #4458

alexec commented Nov 4, 2020 •

edited

alexec commented Nov 4, 2020

alexec commented Nov 5, 2020

alexec commented Nov 10, 2020

sarabala1979 Nov 12, 2020

alexec Nov 13, 2020

alexec commented Nov 16, 2020

alexec commented Nov 30, 2020

feat(controller): Enhanced artifact repository ref. See #3184 #4458

feat(controller): Enhanced artifact repository ref. See #3184 #4458

Conversation

alexec commented Nov 4, 2020 • edited

alexec commented Nov 4, 2020

alexec commented Nov 5, 2020

alexec commented Nov 10, 2020

sarabala1979 Nov 12, 2020

Choose a reason for hiding this comment

alexec Nov 13, 2020

Choose a reason for hiding this comment

alexec commented Nov 16, 2020

alexec commented Nov 30, 2020

alexec commented Nov 4, 2020 •

edited