Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): Prevent tasks with names starting with digit to use either 'depends' or 'dependencies' #4598

Merged
merged 4 commits into from
Nov 30, 2020
Merged

fix(controller): Prevent tasks with names starting with digit to use either 'depends' or 'dependencies' #4598

merged 4 commits into from
Nov 30, 2020

Commits on Nov 30, 2020

  1. fix(controller): Prevent tasks with names starting with digit to use … 

    …either 'depends' or 'dependencies'

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
    @terrytangyuan
    terrytangyuan committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    0bed15d View commit details
    Browse the repository at this point in the history

  2. Add test case 

    Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
    @terrytangyuan
    terrytangyuan committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    22bce2d View commit details
    Browse the repository at this point in the history

  3. Fix test case 

    Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
    @terrytangyuan
    terrytangyuan committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    3cbc31a View commit details
    Browse the repository at this point in the history

  4. Incorporate feedback from Simon 

    Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
    @terrytangyuan
    terrytangyuan committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    cd806ef View commit details
    Browse the repository at this point in the history