fix: Count Workflows with no phase as Pending for metrics #4628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Behar <simbeh7@gmail.com>
simster7
commented
Dec 2, 2020
Comment on lines
+26
to
+27
| // If the object doesn't have a phase set, consider it pending | ||
| return []string{string(v1alpha1.NodePending)}, nil |
There was a problem hiding this comment.
This was our previous behavior.
alexec
approved these changes
Dec 2, 2020
|
Back-ported to v2.12.0-rc5 |
simster7
added a commit
that referenced
this pull request
Dec 10, 2020
Signed-off-by: Simon Behar <simbeh7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4551
Signed-off-by: Simon Behar simbeh7@gmail.com
Checklist: