feat(ui): add countdown to cronWorkflowList Closes #4636 #4641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simster7
suggested changes
Dec 3, 2020
ui/src/app/cron-workflows/components/cron-workflow-list/cron-workflow-list.tsx
Outdated
Show resolved
Hide resolved
ui/src/app/cron-workflows/components/cron-workflow-list/cron-workflow-list.tsx
Outdated
Show resolved
Hide resolved
alexec
reviewed
Dec 3, 2020
|
|
||
| const duration = moment.duration(moment(date).diff(now)).asSeconds(); | ||
|
|
||
| return <>{formatDuration(duration)}</>; |
There was a problem hiding this comment.
Sorry, I don't quite understand the comment,
would you mind providing me more detail
There was a problem hiding this comment.
There is a component called that I think does this
There was a problem hiding this comment.
There's <Moment duration={now} date={date} />.
I thought we want to keep the formatting the same, thus using formatDuration
tczhao
force-pushed
the
master
branch
2 times, most recently
from
c6a0464
to
9097e17
Compare
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
…kage to 1.0.0 react-moment@1.0.0 fixed duration formatting bug, headzoo/react-moment#114 Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
simster7
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tianchu Zhao evantczhao@gmail.com
Checklist:
Closes #4636