Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): Support email for SSO+RBAC. Closes #4612 #4644

Merged
merged 7 commits into from Dec 11, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Dec 3, 2020

Signed-off-by: Alex Collins alex_collins@intuit.com
Closes #4612

Checklist:

Screenshot 2020-12-03 at 12 46 08

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec changed the title feat(server): Support email is SSO. Closes #4612 feat(server): Support email for SSO+RBAC. Closes #4612 Dec 3, 2020
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
Copy link
Contributor Author

alexec commented Dec 7, 2020

Testing by end user was successful.

@alexec alexec marked this pull request as ready for review December 7, 2020 23:32
@alexec
Copy link
Contributor Author

alexec commented Dec 7, 2020

@jessesuen can you please approve the very small + low risk proto changes?

@alexec alexec requested a review from simster7 December 8, 2020 20:39
@alexec
Copy link
Contributor Author

alexec commented Dec 8, 2020

@simster7 @sarabala1979 this has been proto-approved by @jessesuen. Should be easy to review.

@jessesuen jessesuen removed their assignment Dec 9, 2020
@alexec
Copy link
Contributor Author

alexec commented Dec 11, 2020

@simster7 @sarabala1979 bump!

@alexec alexec merged commit 433dc5b into argoproj:master Dec 11, 2020
@alexec alexec deleted the fix-4612 branch December 11, 2020 20:12
@simster7 simster7 mentioned this pull request Dec 15, 2020
22 tasks
@simster7 simster7 mentioned this pull request Jan 25, 2021
19 tasks
simster7 pushed a commit that referenced this pull request Jan 25, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@simster7
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use User Email as Subject in Google OIDC Login
3 participants