feat(ui): Make it easy to use SSO login with CLI. Resolves #4630 #4645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
commented
Dec 3, 2020
| <div className='white-box'> | ||
| <h4>Using Your Login With The CLI</h4> | ||
| <p>Download the latest CLI before you start.</p> | ||
| <div style={{fontFamily: 'monospace', whiteSpace: 'pre', margin: 20}}>{text.replace(argoToken, '[REDACTED]')}</div> |
There was a problem hiding this comment.
we redact the ARGO_TOKEN here
There was a problem hiding this comment.
Why not simply redact it on the original string? It seems argoToken is not used anywhere except to get redacted
There was a problem hiding this comment.
it made it simpler to have a single un-redacted const than two const
Signed-off-by: Alex Collins <alex_collins@intuit.com>
simster7
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4630
Signed-off-by: Alex Collins alex_collins@intuit.com
Checklist: