feat(ui): Replace 3 buttons with drop-down #4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
commented
Dec 5, 2020
| .replace(/\${metadata\.name}/g, props.node.id) | ||
| .replace(/\${status\.startedAt}/g, props.node.startedAt) | ||
| .replace(/\${status\.finishedAt}/g, props.node.finishedAt)}> | ||
| <button |
There was a problem hiding this comment.
does not format correctly with an icon in it, so changed to a
alexec
commented
Dec 5, 2020
| return ( | ||
| <div className='white-box'> | ||
| <div className='white-box__details'>{<AttributeRows attributes={attributes} />}</div> | ||
| <div> | ||
| <button className='argo-button argo-button--base-o' onClick={() => props.onShowYaml && props.onShowYaml(props.node.id)}> |
There was a problem hiding this comment.
had to make them all grey buttons because the -o style button does not have a background fill, so I could not use it for a drop-down item
simster7
approved these changes
Dec 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bugged me and was easy to fix. I tidied up the link button too.
https://share.getcloudapp.com/E0u4zl29
Signed-off-by: Alex Collins alex_collins@intuit.com
Checklist: