fix(ui): DataLoaderDropdown use function=> promise instead of promise. Fixes #4654 #4655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return promise so that promise only get executed in the child component instead of everywhere.. Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
|
Excellent! |
alexec
approved these changes
Dec 7, 2020
alexec
added a commit
that referenced
this pull request
Dec 7, 2020
…hat (#4655) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
|
Back-ported to v2.12.0-rc5 |
simster7
pushed a commit
that referenced
this pull request
Dec 10, 2020
…hat (#4655) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataLoaderDropdown fix input type from promise to function that returns promise
so that promise only gets executed in the child component instead of everywhere..
Sorry about all the trouble
Signed-off-by: Tianchu Zhao evantczhao@gmail.com
Checklist:
Fixes #4654