New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): Fixed reconnection hot-loop. Fixes #4580 #4663
Conversation
Signed-off-by: Alex Collins <alex_collins@intuit.com>
PR in draft mode pending end-user testing. |
@@ -134,8 +134,12 @@ export class WorkflowDetails extends React.Component<RouteComponentProps<any>, W | |||
) | |||
}}> | |||
<div className={classNames('workflow-details', {'workflow-details--step-node-expanded': !!selectedNode})}> | |||
{(this.selectedTabKey === 'summary' && this.renderSummaryTab()) || | |||
(this.state.workflow && ( | |||
{this.state.error ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved error higher up the render stack
@@ -337,7 +340,7 @@ export class WorkflowDetails extends React.Component<RouteComponentProps<any>, W | |||
.map(changeEvent => changeEvent.object) | |||
.subscribe( | |||
workflow => this.setState({workflow, error: null}), | |||
error => this.setState({error}, () => this.loadWorkflow(namespace, name)) | |||
error => this.setState({error}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed hot-loop
PR ready for review as end user testing has been successful. There maybe another PR to address the "resource version too old" problem. |
Back-ported to v2.12.0-rc5 |
Signed-off-by: Alex Collins alex_collins@intuit.com
Fixes #4580
Checklist: