Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update SSO docs to explain how to use the Argo CD Dex instance with Argo Workflows Server #4729

Merged
merged 2 commits into from Dec 14, 2020

Conversation

hobbsh
Copy link
Contributor

@hobbsh hobbsh commented Dec 12, 2020

I am fairly certain this is the correct place for this documentation update but would like to know if there are more places to update as well as this took me quite a while to figure out.

Checklist:

@hobbsh hobbsh changed the title Update SSO docs to explain how to use the Argo CD Dex instance with Argo Workflows Server docs: Update SSO docs to explain how to use the Argo CD Dex instance with Argo Workflows Server Dec 12, 2020
…rgo Workflows Server

Signed-off-by: Wylie Hobbs <wylie-hobbs@pluralsight.com>
Signed-off-by: Wylie Hobbs <wylie-hobbs@pluralsight.com>
@alexec alexec self-assigned this Dec 14, 2020
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only thought on this is it should be generalized to any Dex instance.

@alexec alexec merged commit 86fdd74 into argoproj:master Dec 14, 2020
@hobbsh
Copy link
Contributor Author

hobbsh commented Dec 14, 2020

My only thought on this is it should be generalized to any Dex instance.

That's a good point, it should probably be generalized. Would you like me to go back and generalize it? I do think there is some value in specifying Workflows as I think it's a common use-case (and possibly common pain point) so doing it this way would allow people to find the content a bit easier.

@alexec
Copy link
Contributor

alexec commented Dec 14, 2020

If you'd like - yes please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants