Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Allow Bearer token in server mode. Fixes #4400 #4735

Merged
merged 2 commits into from Dec 14, 2020

Conversation

simster7
Copy link
Member

Fixes #4400

Signed-off-by: Simon Behar simbeh7@gmail.com

Checklist:

Signed-off-by: Simon Behar <simbeh7@gmail.com>
@alexec alexec changed the title fix: Allow Bearer token in server mode fix(server): Allow Bearer token in server mode Dec 14, 2020
@alexec alexec changed the title fix(server): Allow Bearer token in server mode fix(server): Allow Bearer token in server mode. Fixes #4400 Dec 14, 2020
@alexec
Copy link
Contributor

alexec commented Dec 14, 2020

Maybe create dev build and ask user to test?

@@ -31,11 +31,14 @@ func (m Modes) Add(value string) error {
}

func (m Modes) GetMode(authorisation string) (Mode, bool) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all looks good

@simster7 simster7 merged commit ed853eb into argoproj:master Dec 14, 2020
@simster7 simster7 mentioned this pull request Dec 15, 2020
22 tasks
simster7 added a commit that referenced this pull request Dec 15, 2020
Signed-off-by: Simon Behar <simbeh7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auth-mode server fails when Authorization header is passed.
2 participants