fix(executor): Always check if resource has been deleted in checkResourceState() #4738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urceState() Signed-off-by: terrytangyuan terrytangyuan@gmail.com Co-authored-by: merlintang tangrock@gmail.com Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
simster7
approved these changes
Dec 14, 2020
|
thanks so much @terrytangyuan |
simster7
pushed a commit
that referenced
this pull request
Dec 15, 2020
…urceState() (#4738) Signed-off-by: terrytangyuan terrytangyuan@gmail.com Co-authored-by: merlintang tangrock@gmail.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cherry-picked from my colleague's stale PR #4433 as well as address remaining comments from maintainers to move the logic to top of the for loop. cc @simster7 @alexec
Signed-off-by: terrytangyuan terrytangyuan@gmail.com
Co-authored-by: merlintang tangrock@gmail.com
Checklist: