fix(controller): Fixes resource version misuse. Fixes #4714 #4741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
commented
Dec 14, 2020
| @@ -74,7 +74,8 @@ func waitOnOne(serviceClient workflowpkg.WorkflowServiceClient, ctx context.Cont | |||
| req := &workflowpkg.WatchWorkflowsRequest{ | |||
| Namespace: namespace, | |||
| ListOptions: &metav1.ListOptions{ | |||
| FieldSelector: util.GenerateFieldSelectorFromWorkflowName(wfName), | |||
| FieldSelector: util.GenerateFieldSelectorFromWorkflowName(wfName), | |||
| ResourceVersion: "0", | |||
There was a problem hiding this comment.
"0" means, start from the latest version.
alexec
commented
Dec 14, 2020
| @@ -210,13 +211,7 @@ func (s *workflowServer) WatchWorkflows(req *workflowpkg.WatchWorkflowsRequest, | |||
| return nil | |||
| case event, open := <-watch.ResultChan(): | |||
| if !open { | |||
| log.Debug("Re-establishing workflow watch") | |||
There was a problem hiding this comment.
as the client must have re-connection logic, we should not try and mask/mitigate the problem here
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
commented
Dec 14, 2020
| @@ -43,7 +43,22 @@ export default { | |||
| return Observable.create((observer: Observer<any>) => { | |||
| const eventSource = new EventSource(url); | |||
| eventSource.onmessage = x => observer.next(x.data); | |||
| eventSource.onerror = x => observer.error(x); | |||
| eventSource.onerror = x => { | |||
| switch (eventSource.readyState) { | |||
There was a problem hiding this comment.
some users are creating "unknown error" issues - lets provide clearer error message
simster7
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins alex_collins@intuit.com
Checklist: