feat(controller): Add security and cost recommendation conditions

[alexec]

Signed-off-by: Alex Collins alex_collins@intuit.com

Checklist:

• My organization is added to USERS.md.

[terrytangyuan]

Given that this is doc on security from various perspectives, should we add a section on security policy of the project and link to https://github.com/argoproj/argo/blob/master/SECURITY.md?

[alexec]

@simster7 what do you think of adding these as conditions?

[terrytangyuan]

Looks great! It's a good way for users to find out about related features to reduce security risk and costs.

[simster7]

@simster7 what do you think of adding these as conditions?

Will take a look momentarily

[jessesuen]

@simster7 what do you think of adding these as conditions?

Honestly, I feel like adding conditions is a step too far, out of the purview of the controller, and will be annoying for anyone who understands what they are doing and has no way of removing these conditions. e.g. they intentionally do not want to use the GC feature because they have their own out-of-band GC mechanism.

[alexec]

Honestly, I feel like adding conditions is a step too far, out of the purview of the controller.

Ok. I'll revert these changes. Can I get approval for the docs changes?

@jessesuen

[jessesuen]

I pushed my desired doc changes. Conditional approval to remove the conditions which were added.