-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Mutex not being released on step completion #4847
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
437860a
fix: Mutex not being released on step completion
sarabala1979 93e0573
Fixed the Retry Scenario to release the lock
sarabala1979 047da43
Merge remote-tracking branch 'upstream/master' into mutex-1
sarabala1979 b902322
fixed test
sarabala1979 cd6a60b
Merge remote-tracking branch 'upstream/master' into mutex-1
sarabala1979 c9a0838
Update operator_concurrency_test.go
sarabala1979 92c969b
Merge branch 'master' into mutex-1
sarabala1979 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -155,6 +155,7 @@ func (cm *Manager) Release(wf *wfv1.Workflow, nodeName string, syncRef *wfv1.Syn | |
|
||
if syncLockHolder, ok := cm.syncLockMap[lockName.EncodeName()]; ok { | ||
syncLockHolder.release(holderKey) | ||
syncLockHolder.removeFromQueue(holderKey) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is mainly for edge cases to avoid the release node shouldn't be in pending state. |
||
log.Debugf("%s sync lock is released by %s", lockName.EncodeName(), holderKey) | ||
lockKey := lockName.EncodeName() | ||
wf.Status.Synchronization.GetStatus(syncRef.GetType()).LockReleased(holderKey, lockKey) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node status will be calculated here for retry nodes. The lock has to be released if the node is fulfilled