feat: Support specifying the pattern for transient and retryable errors #4889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tryable Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
terrytangyuan
changed the title
alexec
reviewed
Jan 15, 2021
config/config.go
Outdated
| @@ -36,6 +36,10 @@ type Config struct { | |||
| // MainContainer holds container customization for the main container | |||
| MainContainer *apiv1.Container `json:"mainContainer,omitempty"` | |||
|
|
|||
| // TransientErrorPattern specifies the pattern to match for errors that can be seen as transient | |||
| // and retryable. | |||
| TransientErrorPattern string `json:"transientErrorPattern,omitempty"` | |||
There was a problem hiding this comment.
I think this should be a rarely used feature, so an environment variable would be the way to configure it - it is much simpler too.
There was a problem hiding this comment.
In our case, we'd like to whitelist non-critical errors that can be retried for issues during cluster maintenance/migration, etc., especially for non-production clusters where certain services may not be available.
Good suggestion. I'll add an env var to configure this instead.
There was a problem hiding this comment.
Just updated. Please take another look.
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
alexec
reviewed
Jan 18, 2021
| return isExceededQuotaErr(err) || apierr.IsTooManyRequests(err) || isResourceQuotaConflictErr(err) || isTransientNetworkErr(err) || apierr.IsServerTimeout(err) || apierr.IsServiceUnavailable(err) | ||
| // TRANSIENT_ERROR_PATTERN allows to specify the pattern to match for errors that can be seen as transient | ||
| // and retryable. | ||
| pattern, _ := os.LookupEnv("TRANSIENT_ERROR_PATTERN") |
There was a problem hiding this comment.
I think you can move this to matchTransientErr
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
alexec
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: terrytangyuan terrytangyuan@gmail.com
Checklist: