Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): objecteditor only runs onChange when values are modified #4911

Merged
merged 1 commit into from Jan 20, 2021
Merged

fix(ui): objecteditor only runs onChange when values are modified #4911

merged 1 commit into from Jan 20, 2021

Conversation

tczhao
Copy link
Member

@tczhao tczhao commented Jan 20, 2021

Fix UI

Issue:

  • when switching tabs (other -> manifest) in template/cron wf detail views, the submit button becomes disabled despite no change in manifest
  • when toggling yaml<->json in template/cron wf detail view manifest, the submit button becomes disabled despite no change in manifest

Change:

  • only updates text when values are modified in monaco-editor

Signed-off-by: Tianchu Zhao evantczhao@gmail.com

Checklist:

@tczhao tczhao force-pushed the feature/fix-ui-objectediter branch from 280d181 to 31bcf4f Compare January 20, 2021 13:45
@tczhao
fix(ui): objecteditor only runs onChange when values are modified
a8ad141 
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
@tczhao tczhao force-pushed the feature/fix-ui-objectediter branch from 31bcf4f to a8ad141 Compare January 20, 2021 13:46
@alexec alexec merged commit cd7c16b into argoproj:master Jan 20, 2021
@alexec
Copy link
Contributor

alexec commented Jan 20, 2021

LGTM

@tczhao tczhao mentioned this pull request Jan 21, 2021
Merged
1 task
This was referenced Jan 25, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tczhao @alexec