Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crds): Update CRDs to apiextensions.k8s.io/v1 #4918

Merged
merged 3 commits into from Jan 27, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jan 21, 2021

Signed-off-by: Alex Collins alex_collins@intuit.com

Checklist:

@naor2013
Copy link

Is there a way to keep the old version still as well? Either with a helm chart that detects your k8s version automatically or simply by keeping both version and labeling the old version with "old" (for example, "namespace_install_old.yaml")?

@alexec
Copy link
Contributor Author

alexec commented Jan 21, 2021

Is there a way to keep the old version still as well? Either with a helm chart that detects your k8s version automatically or simply by keeping both version and labeling the old version with "old" (for example, "namespace_install_old.yaml")?

What about producing two sets of CRDs?

@naor2013
Copy link

What about producing two sets of CRDs?

That would also help, if there would be 2 versions of CRD and we could choose the "old one".

@alexec
Copy link
Contributor Author

alexec commented Jan 21, 2021

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec merged commit 6e116e4 into argoproj:master Jan 27, 2021
@alexec alexec deleted the crd-version branch January 27, 2021 04:44
@alexec alexec added this to the v3.0 milestone Jan 27, 2021
@naor2013
Copy link

@alexec what about what we wrote here before? Having two sets of CRDs to keep the old version as well?

@alexec
Copy link
Contributor Author

alexec commented Jan 27, 2021

Could you use the old CRDs on the release-2.12 branch?

@naor2013
Copy link

Could you use the old CRDs on the release-2.12 branch?

Now it seems like there isn’t much difference between 2.12 and 3.0 so it’s possible, but the moment you’ll change the yamls in version 3.x, it won’t be possible anymore.

@simster7 simster7 mentioned this pull request Feb 1, 2021
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants