feat: Check the workflow is not being deleted for Synchronization workflow #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
alexec
reviewed
Jan 25, 2021
| if key == "" { | ||
| return "", fmt.Errorf("holderkey is empty") | ||
| } | ||
| items := strings.Split(key, "/") |
There was a problem hiding this comment.
this seems redundant - you just split and then re-join - I think you can always assume namespace/name
There was a problem hiding this comment.
In template level synchronization scenario, Key will have 3 items (including node name)
alexec
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
closes #4905