feat(server): add ServiceAccount info to api/v1/userinfo and ui user tab #4944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
reviewed
Jan 25, 2021
pkg/apiclient/info/info.proto
Outdated
| @@ -26,6 +26,7 @@ message GetUserInfoResponse { | |||
| repeated string groups = 3; | |||
| string email = 4; | |||
| bool emailVerified = 5; | |||
| string serviceAccount = 6; | |||
There was a problem hiding this comment.
I think it should probably be consistent with PodSpec which would be serviceAccountName:
https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/
alexec
approved these changes
Jan 26, 2021
|
I think e2e test failure is unrelated. Re-running. |
|
Please sync with master to fix conflicts introduced by v2. |
alexec
requested changes
Jan 27, 2021
tczhao
force-pushed
the
feature/add-serviceaccount-userinfo
branch
from
63f8bbd
to
01e2988
Compare
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
…o match up with pod.spec Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
tczhao
force-pushed
the
feature/add-serviceaccount-userinfo
branch
from
01e2988
to
7dbc877
Compare
Done |
alexec
approved these changes
Jan 27, 2021
|
@simster7 we might want to back-part this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #4936
Signed-off-by: Tianchu Zhao evantczhao@gmail.com
Checklist: