Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run all executors on CI #4957

Merged
merged 20 commits into from Jan 28, 2021
Merged

ci: Run all executors on CI #4957

merged 20 commits into from Jan 28, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jan 27, 2021

This PR does the following:

  • Enable running kubelet for e2e tests. This needs additional permissions and set-up.
  • Mark all tests with what they "need" to run.

Notable it hints stop and terminate do not work for kubelet and k8sapi executors. @terrytangyuan @dtaniwaki FYI

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec marked this pull request as ready for review January 27, 2021 23:58
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec merged commit 1d8b954 into argoproj:master Jan 28, 2021
@alexec alexec deleted the all branch January 28, 2021 00:51
@terrytangyuan
Copy link
Member

Notable it hints stop and terminate do not work for kubelet and k8sapi executors. @terrytangyuan @dtaniwaki FYI

Got it. Thanks for the info.

@simster7 simster7 mentioned this pull request Feb 1, 2021
32 tasks
@simster7 simster7 mentioned this pull request Feb 8, 2021
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants