Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use button in side panel links #4977

Merged
merged 1 commit into from Jan 29, 2021
Merged

fix: Use button in side panel links #4977

merged 1 commit into from Jan 29, 2021

Conversation

simster7
Copy link
Member

Before:
image

After:
image

Checklist:

@simster7
fix: Use button in side panel links
5ed5870 
Signed-off-by: Simon Behar <simbeh7@gmail.com>
@simster7 simster7 merged commit d324b43 into argoproj:master Jan 29, 2021
@dcherman
Copy link
Member

dcherman commented Feb 1, 2021

Won't this break right click menus and the ability to middle click the link to open it in a new tab? Instead of using a button, we should have a class that we can just apply to the <a> element, that way we don't break the UX

@simster7 simster7 mentioned this pull request Feb 1, 2021
Closed
32 tasks
@simster7 simster7 mentioned this pull request Feb 8, 2021
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees

@alexec alexec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simster7 @dcherman @alexec