fix(controller): Adds PNS_PRIVILEGED, fixed termination bug #4983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
changed the title
alexec
commented
Feb 1, 2021
| @@ -293,25 +281,6 @@ spec: | |||
| }) | |||
| } | |||
|
|
|||
| func (s *FunctionalSuite) TestFastFailOnPodTermination() { | |||
alexec
commented
Feb 1, 2021
| @@ -554,87 +523,6 @@ func (s *FunctionalSuite) TestParameterAggregation() { | |||
| }) | |||
| } | |||
|
|
|||
| func (s *FunctionalSuite) TestGlobalScope() { | |||
| s.Need(fixtures.BaseLayerArtifacts) | |||
There was a problem hiding this comment.
deleted - this test is flakey and it was a time suck fixing it
alexec
commented
Feb 1, 2021
| @@ -1116,38 +1116,29 @@ func (woc *wfOperationCtx) assessNodeStatus(pod *apiv1.Pod, node *wfv1.NodeStatu | |||
| } | |||
| newDaemonStatus = pointer.BoolPtr(false) | |||
| case apiv1.PodRunning: | |||
| if pod.DeletionTimestamp != nil { | |||
There was a problem hiding this comment.
this condition is incorrect - a pod with a deletion timestamp is one we may have caused to be deleted ourselves - this was incorrect marking nodes as error when they should have been failed
simster7
approved these changes
Feb 1, 2021
|
can this be cherry picked for v2.x? |
|
This is too big to back-port all of it really. Is there a specific thing you need from it? |
|
will it be easy transition to v3.x? no specific need, just running this using onepanel on microk8s with pns and getting alot of crashes |
|
Most user should not have any migration issues to v3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed the need to run ALL tests.
New suites:
I've deleted a few tests (see my comments).
Fixed a bug that marked some workflows as an error when they should have been failed.
Added PNS_PRIVILEGED to run PNS in privileged mode, sometimes needed for GCP.