fix: Fail DAG templates with variables with invalid dependencies

[changhc]

This PR fixes #2314 . It was closed since I didn't create the PR in time.

Actually a test case for this issue already exists, but the fixture was set up incorrectly such that the test didn't capture this issue.

Tested locally for both artifacts and parameters with the following sample:

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: output-parameter-
spec:
  entrypoint: abc
  templates:
  - name: abc
    dag:
      tasks:
        - name: generate-parameter
          template: whalesay
        - name: consume-parameter
          template: print-message
          dependencies: ["generate-parameter"]
          arguments:
            parameters:
            - name: message
              value: "{{tasks.generate-parameter.outputs.parameters.hello-param}}"
            artifacts:
            - name: message2
              from: "{{tasks.generate-parameter.outputs.artifacts.hello-art}}"
  - name: whalesay
    container:
      image: docker/whalesay:latest
      command: [sh, -c]
      args: ["sleep 1; echo -n hello world > /tmp/hello_world.txt"]
    outputs:
      parameters:
      - name: hello-param
        valueFrom:
          path: /tmp/hello_world.txt
      artifacts:
      - name: hello-art
        path: /tmp/hello_world.txt
  - name: print-message
    inputs:
      parameters:
      - name: message
    container:
      image: docker/whalesay:latest
      command: [cowsay]
      args: ["{{inputs.parameters.message}}"]

Commenting out dependencies: ["generate-parameter"] raises an error like this:
Failed to submit workflow: templates.abc.tasks.consume-parameter missing dependency 'generate-parameter' for parameter 'message'

But this sample indicates another issue: template print-message does not accept input artifacts, but argo does not throw an error when parsing the definition of task consume-parameter. Should this be fixed as well?

Checklist:

• My organization is added to USERS.md.

[simster7]

Reopened issue, will take a look at this today

[simster7]

Please make sure you sign your commits according to https://github.com/argoproj/argo/pull/4992/checks?check_run_id=1813331712

[changhc]

Sorry about messing up the commits. It should have been fixed now.

[simster7]

But this sample indicates another issue: template print-message does not accept input artifacts, but argo does not throw an error when parsing the definition of task consume-parameter. Should this be fixed as well?

Sure, why not

[simster7]

LGTM