Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Upgrade Golang to v1.15 #5009

Merged
merged 5 commits into from Feb 3, 2021
Merged

build: Upgrade Golang to v1.15 #5009

merged 5 commits into from Feb 3, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 3, 2021

No description provided.

@alexec
feat: Upgrade to Golang v1.15
8e7d50e 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec requested a review from simster7 February 3, 2021 18:46
@alexec alexec changed the title feat: Upgrade to Golang v1.15 build: Upgrade to Golang v1.15 Feb 3, 2021
@alexec alexec added the type/security Security related label Feb 3, 2021
@alexec alexec changed the title build: Upgrade to Golang v1.15 build: Upgrade Golang to v1.15 Feb 3, 2021
@alexec alexec marked this pull request as ready for review February 3, 2021 19:19
simster7
simster7 reviewed Feb 3, 2021
View reviewed changes
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does go.mod need to be updated as well?

simster7
simster7 approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approval on go.mod change

@alexec
Merge branch 'master' into go-15
46e587e 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
feat: Upgrade to Golang v1.15
067c243 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
feat: Upgrade to Golang v1.15
09b37b9 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
feat: Upgrade to Golang v1.15
d856b1f 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec merged commit 1b77ec8 into argoproj:master Feb 3, 2021
@alexec alexec deleted the go-15 branch February 3, 2021 20:22
@simster7 simster7 mentioned this pull request Feb 8, 2021
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

Assignees
No one assigned
Labels
type/security Security related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexec @simster7