fix: Append the error message prior to offloading node status

[terrytangyuan]

Currently if offloading is not enabled and if the workflow is too large, we will only see offload node status is not supported and the original error message is lost/masked. We'd like to expose that information so users will know their workflow is too large by how much and know what to do next.

Signed-off-by: terrytangyuan terrytangyuan@gmail.com

Checklist:

• My organization is added to USERS.md.

[alexec]

I don't understand this fix. This code branch should only even execute if the error is workflow is longer than maximum allowed size..

[terrytangyuan]

it is impossible for this to happen AFAIK - alwaysOffloadNodeStatus must always false , so the error must be IsTooLargeError

@alexec We are observing error messages like offload node status is not supported in our workflows which confused our users and the original error message is masked. Here's what the new error message looks like (it's the new test case I added in this PR):

workflow is longer than maximum allowed size. compressed size 317 > maxSize 260. Tried to offload but encountered error: offload node status is not supported

I don't understand this fix. This code branch should only even execute if the error is workflow is longer than maximum allowed size..

Perhaps I misunderstood something here but the code would also execute when alwaysOffloadNodeStatus == true.

@alexec's comments

[alexec]

Please sync with master.

[terrytangyuan]

@alexec Rebased but outdated again. I thought rebasing is done after approved and before merging?