feat: Support pgzip as an alternative (de)compression implementation #5108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
reviewed
Feb 15, 2021
alexec
reviewed
Feb 16, 2021
| "k8s.io/utils/env" | ||
| ) | ||
|
|
||
| var gzipImpl = env.GetString(GZipImplEnvVarKey, PGZIP) |
There was a problem hiding this comment.
I did not know about this library - neat
There was a problem hiding this comment.
Yea it's super fast and works great for large workflows.
alexec
reviewed
Feb 16, 2021
util/file/fileutil.go
Outdated
| @@ -63,23 +73,52 @@ func DecodeDecompressString(content string) (string, error) { | |||
| return string(dBuf), nil | |||
| } | |||
|
|
|||
| type GZipWriter interface { | |||
There was a problem hiding this comment.
isn't this the same interface as io.Writer?
There was a problem hiding this comment.
It's not since io.Writer does not implement Close(). However I just found io.WriteCloser which is exactly what I needed. Just switched.
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
alexec
reviewed
Feb 16, 2021
util/file/fileutil.go
Outdated
| case GZIP: | ||
| gzipReader, err = gzip.NewReader(buf) | ||
| default: | ||
| log.Infof("%s implementation for decompression is not supported. Fallback to PGZip.", gzipImpl) |
There was a problem hiding this comment.
remove this logging - not needed
alexec
reviewed
Feb 16, 2021
util/file/fileutil.go
Outdated
| gzipReader, err = pgzip.NewReader(buf) | ||
| } | ||
| if err != nil { | ||
| log.Warnf("Error in decompressing: %v", err) |
alexec
reviewed
Feb 16, 2021
util/file/fileutil.go
Outdated
| } | ||
| if err != nil { | ||
| log.Warnf("Error in decompressing: %v", err) | ||
| return nil, err |
There was a problem hiding this comment.
fmt.Errorf("failed to decompress: %w", err)
alexec
reviewed
Feb 16, 2021
util/file/fileutil.go
Outdated
| case GZIP: | ||
| gzipWriter = gzip.NewWriter(&buf) | ||
| default: | ||
| log.Infof("%s implementation for compression is not supported. Fallback to PGZip.", gzipImpl) |
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
alexec
approved these changes
Feb 16, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For relatively large workflows, using pgzip to parallelize the (de)compression would greatly speed up the (de)hydration process, especially when the size overhead during compression can be neglected.
Signed-off-by: terrytangyuan terrytangyuan@gmail.com
Checklist: