fix: Multiple UI fixes #5140
Merged
fix: Multiple UI fixes #5140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Behar <simbeh7@gmail.com>
alexec
reviewed
Feb 18, 2021
| @@ -266,7 +266,7 @@ export class WorkflowsList extends BasePage<RouteComponentProps<any>, State> { | |||
| )} | |||
| <div className='argo-table-list'> | |||
| <div className='row argo-table-list__head'> | |||
| <div className='columns workflows-list__status small-1' /> | |||
| <div className='columns small-1 workflows-list__status' /> | |||
| <div className='row small-11'> | |||
There was a problem hiding this comment.
This is correct. It's completed by a small-1 right above
There was a problem hiding this comment.
It was actually incorrect, but for a different reason. Good catch :)
alexec
approved these changes
Feb 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
