Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add argo submit --verify hidden flag. Closes #5136 #5141

Merged
merged 4 commits into from Feb 19, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 18, 2021

No description provided.

@@ -67,8 +67,6 @@ func waitWorkflows(ctx context.Context, serviceClient workflowpkg.WorkflowServic
}

func waitOnOne(serviceClient workflowpkg.WorkflowServiceClient, ctx context.Context, wfName, namespace string, ignoreNotFound, quiet bool) bool {
ctx, cancel := context.WithCancel(ctx)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-existing bug

@alexec alexec linked an issue Feb 18, 2021 that may be closed by this pull request
@alexec alexec changed the title feat: Add argo submit --verify hiddenflag feat: Add argo submit --verify hidden flag. Closes #5136 Feb 18, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec marked this pull request as ready for review February 19, 2021 04:07
@alexec alexec requested a review from simster7 February 19, 2021 16:29
@alexec alexec merged commit 590df1d into argoproj:master Feb 19, 2021
@alexec alexec deleted the verify branch February 19, 2021 17:17
@simster7 simster7 mentioned this pull request Feb 23, 2021
34 tasks
@simster7 simster7 mentioned this pull request Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add argo test or maybe argo submit --wait --verify command
2 participants