fix(ui): Fix node filters in UI #5162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Behar <simbeh7@gmail.com>
simster7
commented
Feb 22, 2021
| (!nodeClassNames || Object.entries(nodeClassNames).find(([className, checked]) => checked && (label.classNames || '').split(' ').includes(className))) && | ||
| (!nodeTags || Object.entries(nodeTags).find(([tag, checked]) => !label.tags || (checked && label.tags.has(tag)))) && | ||
| !nodeSearchKeyword) || | ||
| label.label.includes(nodeSearchKeyword) |
There was a problem hiding this comment.
This line broke the filter. If nodeSearchKeyword was empty it would match all nodes, rendering the filter moot
alexec
reviewed
Feb 22, 2021
| return true; | ||
| } | ||
| // If the node doesn't match enabled genres, don't display | ||
| if (!nodeGenres[label.genre]) { |
There was a problem hiding this comment.
I spent some time trying, but it's a pain: will need to extract the function out of the component, create parameters for props and all the required variables, and then mock them in the test. I'd be happy to do so, but don't think it's worth it. Thoughts?
There was a problem hiding this comment.
sounds like poor roi, leave it
There was a problem hiding this comment.
@alexec Ready for review then
alexec
approved these changes
Feb 23, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: