feat(controller): Allow to modify time related configurations in leader election #5234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er election Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
|
cc @sarabala1979 Could you take a look at this too? |
sarabala1979
approved these changes
Feb 26, 2021
simster7
pushed a commit
that referenced
this pull request
Mar 2, 2021
…er election (#5234) Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our large clusters were under high load the other day and the current lease/leader configuration needs to be adjusted to avoid frequent leader election and reduce etcd’s pressure under such load. Otherwise, the etcd server would not be able to handle too many requests and fail with error like
Failed to update lock: etcdserver: too many requests, which leads to periodically restart of the controller.This PR exposes relevant configurations via environment variables.
Signed-off-by: terrytangyuan terrytangyuan@gmail.com
Checklist: