feat(executor): Move exit code capture to controller. See #5251 #5254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
simster7
reviewed
Mar 2, 2021
Comment on lines
+1202
to
+1209
| if node.Outputs != nil && node.Outputs.ExitCode == nil { | ||
| for _, c := range pod.Status.ContainerStatuses { | ||
| if c.Name == common.MainContainerName && c.State.Terminated != nil { | ||
| node.Outputs.ExitCode = pointer.StringPtr(fmt.Sprint(c.State.Terminated.ExitCode)) | ||
| updated = true | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
why have buggy code in the executor where it is hard to test when you can have that buggy code in the controller
There was a problem hiding this comment.
This code should run before PodGC. I think it should be. we need to test the edge cases.
There was a problem hiding this comment.
This runs whenever the exit code is known (because the container is terminated) but has not been set yet.
I'm doubling-down on this refactoring.
|
Closing. Re-opening shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5251