Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(executor): Enhance PNS executor. Resolves #5251 #5296

Merged
merged 5 commits into from
Mar 4, 2021
Merged

fix(executor): Enhance PNS executor. Resolves #5251 #5296

merged 5 commits into from
Mar 4, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Mar 4, 2021 •
edited
Loading

Resolves #5251

Changes:

  • We actually don't need the container ID, so I can delete some code.
  • We cannot assume that short-running containers have completed, they maybe late-starting.

@alexec
fix(executor): Enhance PNS executor. Resolves #5251
b0b888f 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec marked this pull request as ready for review March 4, 2021 17:13
@alexec
Merge branch 'master' into dev-pns
e3fde79 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
fix(executor): Enhance PNS executor. Resolves #5251
f8d6b14 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
fix(executor): Enhance PNS executor. Resolves #5251
5f4b802 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
fix(executor): Enhance PNS executor. Resolves #5251
8c8229a 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec merged commit 757e0be into master Mar 4, 2021
@alexec alexec deleted the dev-pns branch March 4, 2021 20:07
This was referenced Mar 8, 2021
Closed
Closed
simster7 pushed a commit that referenced this pull request Mar 8, 2021
@alexec @simster7
fix(executor): Enhance PNS executor. Resolves #5251 (#5296)
f368c32
@simster7 simster7 mentioned this pull request Apr 19, 2021
Closed
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarabala1979 sarabala1979 sarabala1979 approved these changes

@jessesuen jessesuen Awaiting requested review from jessesuen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workflow - Could not get container status
2 participants
@alexec @sarabala1979