fix(executor): Delegate PNS wait to K8SAPI executor. #5307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
commented
Mar 5, 2021
| } | ||
|
|
||
| OUTER: | ||
| for _, containerName := range containerNames { |
There was a problem hiding this comment.
Very rarely, containers can successfully complete, but the Kubernetes API does not yet know about it, so kubectl logs will then fail, resulting in the wait container failing.
I don't see any easy way around this, so this reverts us to how v2.12.
It's a shame to lose this performance boost, but a much worse shame to have unpredictable workflow failures.
Signed-off-by: Alex Collins <alex_collins@intuit.com>
|
@sarabala1979 bump! |
sarabala1979
reviewed
Mar 6, 2021
| @@ -58,12 +58,7 @@ func (k *K8sAPIExecutor) GetExitCode(ctx context.Context, containerName string) | |||
| // Wait for the container to complete | |||
| func (k *K8sAPIExecutor) Wait(ctx context.Context, containerNames, sidecarNames []string) error { | |||
There was a problem hiding this comment.
Don't we terminate Sidecar containers also?
sarabala1979
approved these changes
Mar 6, 2021
This was referenced Mar 8, 2021
Closed
Closed
simster7
pushed a commit
that referenced
this pull request
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.