fix: Disallow object names with more than 63 chars #5324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Behar <simbeh7@gmail.com>
workflow/validate/validate.go
Outdated
| @@ -108,6 +108,10 @@ func ValidateWorkflow(wftmplGetter templateresolution.WorkflowTemplateNamespaced | |||
| var wfTmplRef *wfv1.TemplateRef | |||
| var err error | |||
|
|
|||
| if len(wf.Name) > 63 { | |||
| return nil, fmt.Errorf("workflow name '%s' must not be more than 63 characters long (currently %d)", wf.Name, len(wf.Name)) | |||
There was a problem hiding this comment.
Minor: could use %q when quoting string
workflow/validate/validate.go
Outdated
| @@ -108,6 +108,10 @@ func ValidateWorkflow(wftmplGetter templateresolution.WorkflowTemplateNamespaced | |||
| var wfTmplRef *wfv1.TemplateRef | |||
| var err error | |||
|
|
|||
| if len(wf.Name) > 63 { | |||
alexec
approved these changes
Mar 8, 2021
This was referenced Mar 8, 2021
Closed
Closed
simster7
added a commit
that referenced
this pull request
Mar 8, 2021
Signed-off-by: Simon Behar <simbeh7@gmail.com>
simster7
added a commit
that referenced
this pull request
Mar 8, 2021
Signed-off-by: Simon Behar <simbeh7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5318
Signed-off-by: Simon Behar simbeh7@gmail.com
Checklist: