Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(executor) Add injected sidecar support to Emissary #5383

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Mar 12, 2021

No description provided.

@alexec alexec changed the title Dev emissary feat(executor) Add injected sidecar support to Emissary Mar 12, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec added this to the v3.1 milestone Mar 15, 2021
@alexec alexec marked this pull request as ready for review March 15, 2021 18:06
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #5383 (a470432) into master (8e13758) will decrease coverage by 0.00%.
The diff coverage is 3.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5383      +/-   ##
==========================================
- Coverage   16.21%   16.21%   -0.01%     
==========================================
  Files         243      243              
  Lines       43697    43729      +32     
==========================================
+ Hits         7086     7089       +3     
- Misses      35640    35674      +34     
+ Partials      971      966       -5     
Impacted Files Coverage Δ
workflow/controller/controller.go 20.25% <0.00%> (-0.92%) ⬇️
workflow/controller/pod_cleanup_key.go 20.00% <ø> (ø)
workflow/controller/operator.go 70.67% <12.50%> (-0.15%) ⬇️
workflow/metrics/server.go 12.76% <0.00%> (-4.26%) ⬇️
server/workflow/workflow_server.go 40.45% <0.00%> (-2.28%) ⬇️
cmd/argo/commands/get.go 57.33% <0.00%> (+0.66%) ⬆️
cmd/argoexec/commands/emissary.go 50.00% <0.00%> (+1.56%) ⬆️
workflow/controller/exec_control.go 59.34% <0.00%> (+6.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e13758...bd73d44. Read the comment docs.

@alexec alexec merged commit d3eeddb into argoproj:master Mar 16, 2021
@alexec alexec deleted the dev-emissary branch March 16, 2021 17:30
@simster7 simster7 mentioned this pull request Mar 22, 2021
34 tasks
@simster7 simster7 mentioned this pull request Mar 29, 2021
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants