Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(executor): Ignore non-running Docker kill errors #5451

Merged
merged 3 commits into from Mar 19, 2021
Merged

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Mar 18, 2021

No description provided.

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec linked an issue Mar 18, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #5451 (a0878b2) into master (3b129a8) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head a0878b2 differs from pull request most recent head 4d79713. Consider uploading reports for the commit 4d79713 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5451      +/-   ##
==========================================
- Coverage   16.30%   16.29%   -0.02%     
==========================================
  Files         243      243              
  Lines       43675    43675              
==========================================
- Hits         7121     7115       -6     
- Misses      35582    35588       +6     
  Partials      972      972              
Impacted Files Coverage Δ
workflow/metrics/server.go 12.76% <0.00%> (-4.26%) ⬇️
cmd/argoexec/commands/emissary.go 48.43% <0.00%> (-1.57%) ⬇️
cmd/argo/commands/get.go 56.66% <0.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b129a8...4d79713. Read the comment docs.

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec marked this pull request as ready for review March 18, 2021 23:35
@alexec alexec requested a review from whynowy March 18, 2021 23:35
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec added this to the v3.0 milestone Mar 19, 2021
@alexec alexec merged commit d9f2010 into master Mar 19, 2021
@alexec alexec deleted the dev-docker branch March 19, 2021 02:46
@simster7 simster7 mentioned this pull request Mar 22, 2021
34 tasks
simster7 pushed a commit that referenced this pull request Mar 23, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@simster7 simster7 mentioned this pull request Mar 29, 2021
77 tasks
@simster7 simster7 mentioned this pull request Apr 19, 2021
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3.0: wait containers do not exit
2 participants