feat: Support Arguments in Exit Handler #5455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #5455 +/- ##
==========================================
+ Coverage 47.03% 47.36% +0.32%
==========================================
Files 246 247 +1
Lines 15485 15614 +129
==========================================
+ Hits 7283 7395 +112
Misses 7290 7290
- Partials 912 929 +17
Continue to review full report at Codecov.
|
|
This is really cool. We need something like this to pass parameters to exit handlers from certain steps. |
alexec
reviewed
Apr 2, 2021
alexec
reviewed
Apr 2, 2021
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
alexec
changed the title
alexec
reviewed
Apr 12, 2021
alexec
reviewed
Apr 12, 2021
alexec
reviewed
Apr 12, 2021
alexec
reviewed
Apr 12, 2021
alexec
reviewed
Apr 13, 2021
alexec
reviewed
Apr 13, 2021
alexec
reviewed
Apr 13, 2021
alexec
reviewed
Apr 13, 2021
alexec
requested changes
Apr 16, 2021
| @@ -750,6 +749,9 @@ func (ctx *templateValidationCtx) validateSteps(scope map[string]interface{}, tm | |||
| if err != nil { | |||
| return errors.Errorf(errors.CodeBadRequest, "templates.%s.steps[%d].%s %s", tmpl.Name, i, step.Name, err.Error()) | |||
| } | |||
| if step.HasExitHook() { | |||
There was a problem hiding this comment.
do we need to guard this at all?
There was a problem hiding this comment.
yes, Including the current step/task variables should be only for exithook.
alexec
reviewed
Apr 28, 2021
alexec
reviewed
Apr 29, 2021
alexec
reviewed
May 3, 2021
alexec
approved these changes
May 5, 2021
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Saravanan Balasubramanian sarabala1979@gmail.com
closes #5452
closes #4631
Checklist: