Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Handling panic in go routines #5489

Merged
merged 3 commits into from
Mar 24, 2021

Conversation

sarabala1979
Copy link
Member

Signed-off-by: Saravanan Balasubramanian sarabala1979@gmail.com

Checklist:

closes #5411

Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #5489 (9daa6cb) into master (9390190) will increase coverage by 0.03%.
The diff coverage is 17.64%.

❗ Current head 9daa6cb differs from pull request most recent head 5fca771. Consider uploading reports for the commit 5fca771 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5489      +/-   ##
==========================================
+ Coverage   46.59%   46.63%   +0.03%     
==========================================
  Files         240      240              
  Lines       14985    15001      +16     
==========================================
+ Hits         6982     6995      +13     
  Misses       7105     7105              
- Partials      898      901       +3     
Impacted Files Coverage Δ
config/controller.go 21.53% <0.00%> (-0.34%) ⬇️
workflow/cron/controller.go 0.00% <0.00%> (ø)
workflow/metrics/server.go 16.66% <0.00%> (-0.36%) ⬇️
workflow/controller/controller.go 20.07% <10.00%> (-0.19%) ⬇️
workflow/controller/operator.go 70.20% <100.00%> (-0.06%) ⬇️
workflow/sync/sync_manager.go 71.59% <100.00%> (+0.16%) ⬆️
cmd/argo/commands/get.go 57.33% <0.00%> (+0.66%) ⬆️
cmd/argoexec/commands/emissary.go 50.00% <0.00%> (+1.56%) ⬆️
server/workflow/workflow_server.go 42.73% <0.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9390190...5fca771. Read the comment docs.

@sarabala1979 sarabala1979 marked this pull request as ready for review March 23, 2021 23:25
@sarabala1979 sarabala1979 merged commit c8645fc into argoproj:master Mar 24, 2021
This was referenced Mar 29, 2021
simster7 pushed a commit that referenced this pull request Mar 30, 2021
simster7 pushed a commit that referenced this pull request Apr 5, 2021
@simster7 simster7 mentioned this pull request Apr 19, 2021
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle panics in Goroutines
2 participants